Skip to content

Fix issues and awesome improvements in fmesh functionality #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gilbertogalvis
Copy link
Contributor

This PR fix issues and do awesome improvements with fmesh functionality. fmesh previous version was very poor. This new version is really awesome. This PR was tested for all examples in https://github.com/plotly/ssim_baselines/tree/main/matlab/code-examples/surface-and-mesh-plots/fmesh

It is very important to highlight that to use this new functionality, TreatAs optional parameter must set to fmesh. Example of usage bellow

r = @(s,t) 2 + sin(7.*s + 5.*t);
x = @(s,t) r(s,t).*cos(s).*sin(t);
y = @(s,t) r(s,t).*sin(s).*sin(t);
z = @(s,t) r(s,t).*cos(t);
fmesh(x,y,z,[0 2*pi 0 pi]);

f = fig2plotly(gcf, 'offline', 0, 'TreatAs', 'fmesh');

Screenshots of results are shown bellow

Screen Shot 2021-09-11 at 9 57 10 PM

Screen Shot 2021-09-11 at 9 57 44 PM

Screen Shot 2021-09-11 at 9 58 35 PM

Screen Shot 2021-09-11 at 9 59 03 PM

Screen Shot 2021-09-11 at 9 59 29 PM

Screen Shot 2021-09-11 at 9 59 59 PM

Links to Chart-Studio

https://chart-studio.plotly.com/~galvisgilberto/4238/#/
https://chart-studio.plotly.com/~galvisgilberto/4240/#/
https://chart-studio.plotly.com/~galvisgilberto/4242/#/
https://chart-studio.plotly.com/~galvisgilberto/4244/#/
https://chart-studio.plotly.com/~galvisgilberto/4246/#/
https://chart-studio.plotly.com/~galvisgilberto/4248/#/

@gilbertogalvis gilbertogalvis merged commit ea58447 into master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants