Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves re-login experience. Closes #342, #374 #358

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Improves re-login experience. Closes #342, #374 #358

merged 3 commits into from
Dec 9, 2024

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 22, 2024 •
edited
Loading

🎯 Aim

The aim improve and simplify login behavior for SPFx Toolkit and try to fixup a strange issue with login output when cli command is executed.

✅ What was done

  • updated login method from device code to browser to simplified the process
  • added saving clientId and tenantId to global state

🔗 Related issue

Closes #342, #374

@Adam-it Adam-it linked an issue Nov 22, 2024 that may be closed by this pull request
💡 [Feature]: Improve re-login experience #342
Closed
@Adam-it Adam-it self-assigned this Nov 22, 2024
@Adam-it Adam-it force-pushed the improve-login-behavior branch from 89295fa to eb0f2e2 Compare December 3, 2024 09:07
@Adam-it Adam-it marked this pull request as ready for review December 3, 2024 09:07
@Adam-it Adam-it changed the title Improves re-login experience. Closes #342 Improves re-login experience. Closes #342, #374 Dec 4, 2024
@Adam-it Adam-it linked an issue Dec 4, 2024 that may be closed by this pull request
🐞 Bug report: Token expires and we need to manually sign out and sign in #374
Closed
Adam-it
Adam-it commented Dec 4, 2024
View reviewed changes
Copy link
Member Author

@Adam-it Adam-it left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I should update the docs.
  • I should add notify when token expires with relogin message. Now it is present only in extension output

@Adam-it Adam-it marked this pull request as draft December 4, 2024 11:34
@Adam-it Adam-it marked this pull request as ready for review December 9, 2024 21:29
@Adam-it Adam-it force-pushed the improve-login-behavior branch from 97c9626 to d61f22d Compare December 9, 2024 21:29
@Adam-it
Copy link
Member Author

Adam-it commented Dec 9, 2024

  • I should update the docs.
  • I should add notify when token expires with relogin message. Now it is present only in extension output

I will update the readme when doring a minor release as it requires more restructuring and work

@Adam-it Adam-it merged commit 81c3ea6 into pnp:dev Dec 9, 2024
@Adam-it Adam-it deleted the improve-login-behavior branch December 9, 2024 21:36
Adam-it added a commit that referenced this pull request Dec 10, 2024
@Adam-it
Improves re-login experience. Closes #342, #374 (#358)
fb33272 
## 🎯 Aim

The aim is to improve and simplify login behavior for SPFx Toolkit and try to
fixup a strange issue with login output when cli command is executed.

## ✅ What was done

- [x] updated login method from device code to browser to simplify the
process
- [x] added saving clientId and tenantId to the global state

## 🔗 Related issue

Closes #342, #374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Adam-it