Skip to content

include date param in get_ticker_details #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

include date param in get_ticker_details #321

merged 1 commit into from
Oct 31, 2022

Conversation

jakekdodd
Copy link
Contributor

@jakekdodd jakekdodd commented Oct 30, 2022 •
edited
Loading

Fixes #320

I put a second assert in the same test method, but happy to factor the expected response data out and create a second test method, if you prefer to follow the "one assertion per test" paradigm

clickingbuttons
clickingbuttons approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@clickingbuttons clickingbuttons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did nothing wrong... /s
empire logo

Thanks for the catch! I'll cut a release shortly.

@clickingbuttons clickingbuttons merged commit 1c75361 into polygon-io:master Oct 31, 2022
@clickingbuttons
Copy link
Contributor

Released in v1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darcy-Linde Darcy-Linde Awaiting requested review from Darcy-Linde

1 more reviewer

@clickingbuttons clickingbuttons clickingbuttons approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_ticker_details doesn't include the date param
2 participants
@jakekdodd @clickingbuttons