Fix null in array #375
Closed
Fix null in array #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone117x
reviewed
May 24, 2022
| @@ -243,7 +243,7 @@ export const arraySerializer = function arraySerializer(xs, serializer) { | |||
| if (Array.isArray(first) && !first.type) | |||
| return '{' + xs.map(x => arraySerializer(x, serializer)).join(',') + '}' | |||
|
|
|||
| return '{' + xs.map(x => | |||
| return '{' + xs.map(x => x == null ? 'null' : | |||
There was a problem hiding this comment.
Doesn't this library only use strict equality comparisons?
There was a problem hiding this comment.
Yes, this isn't going in.. I've already got a fix for this in the works, so closing the PR
There was a problem hiding this comment.
You use whatever equality comparison is needed, this fix works great
|
Something is already on the way, but thanks anyway ;) |
|
Ok could have said something like 5 days ago so I don't need to fix your library for you, thanks |
|
I haven't asked you to, and I have other things to do than responding to ungrateful people I don't know on the internet. The way you've been conducting yourself previously doesn't really help either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #371