Skip to content

Handle CFBot timeout errors correctly #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JelteF opened this issue Feb 21, 2025 · 0 comments · Fixed by #46
Closed

Handle CFBot timeout errors correctly #39

JelteF opened this issue Feb 21, 2025 · 0 comments · Fixed by #46
Labels
bug Something isn't working

Comments

@JelteF
Copy link
Collaborator

JelteF commented Feb 21, 2025

We currently do not use the branch status at all. But we probably should. At least in the case where there are no known tasks at all. Currently a "timeout" branch status is not correctly reflected. From the discord:

@JelteF #4677 is showing as in progress on the cf app, but cfbot gave up on it and set the branch to "timeout". looks like cirrus/github flaked out on us with "FAILED_PRECONDITION: GitHub API failure!!". that's not our fault but i realise now that in the place in cfbot_util.py where the gc() function whacks b0rked branches with "timeout", it probably needs to dump a push-branch-status job into work_queue to tell the cf. don't have time to work on it right now and it'll clear itself on the cf page soon enough when it is re-scheduled for a bitrot check (no quadratic backoff for timed out branches, only failed tasks), so just noting the observation here...
Thomas Munro — Today at 02:10
additional clue: i manually did
insert into work_queue (type, key, status) values ('post-branch-status', '188732', 'NEW');
and it posted the notification, but it didn't change the display so perhaps the cf app doesn't understand status "timeout" yet

@JelteF JelteF added the bug Something isn't working label Feb 21, 2025
@JelteF JelteF closed this as completed in #46 Mar 1, 2025
JelteF added a commit that referenced this issue Mar 1, 2025
If things take too long, then CFBot will mark the build as timed out.
Such builds would not have that "timeout" status reflected correctly,
and would be displayed as running forever.

Fixes #39
JelteF added a commit that referenced this issue Mar 17, 2025
If things take too long, then CFBot will mark the build as timed out.
Such builds would not have that "timeout" status reflected correctly,
and would be displayed as running forever.

Fixes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant