Skip to content

Have "CI status" column sort by "time since build failed" #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JelteF opened this issue Feb 27, 2025 · 0 comments · Fixed by #47
Closed

Have "CI status" column sort by "time since build failed" #42

JelteF opened this issue Feb 27, 2025 · 0 comments · Fixed by #47

Comments

@JelteF
Copy link
Collaborator

JelteF commented Feb 27, 2025

From a discussion on discord:

How about if sorting by "CI status" would sort by "time since build failed"? Then clicking that header once would show you all non-failing builds at the top, followed by things that only recently became needs-rebase or failing.

This might need some small database changes, because I'm not sure that we're tracking this info currently for failing builds. We only do so for needs-rebase builds currently afaik.

@JelteF JelteF closed this as completed in 47d1197 Mar 1, 2025
JelteF added a commit that referenced this issue Mar 17, 2025
This adds a new column to the `CfbotBranch` model: `failing_since`. This
tracks when a patch first started to fail the CI or started requiring a
rebase. This value its primary use is to allow people to sort by the
"CI status" column in the patch list. This allows people to quickly see
what patches are healthy, which require the author to take action, and
which might benefit from a reviewer pinging the author that the patch
has been broken for a while. Non-failing builds are sorted on their CI
build creation time, so patches that are currently running CI are shown
at the top, followed by patches for which CI succeeded most recently.

The values of needs_rebase_since and failing_since are also shown on
hover and on the patch pages.

Fixes #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant