Skip to content

Penultimate attachment is shown as the latest #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pjungwir opened this issue Mar 21, 2025 · 3 comments
Open

Penultimate attachment is shown as the latest #60

pjungwir opened this issue Mar 21, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@pjungwir
Copy link

pjungwir commented Mar 21, 2025 •
edited
Loading

Thanks for all your work on the commitfest app! It has received some great improvements lately.

I created this commitfest entry to replace my previous one (since it was partly committed, and the committer asked for a new entry for post-v18 work).

I created the entry a little after sending an email to pgsql-hackers with a v50 patch series. But for some reason the app thinks
my latest patch is v49 from 2/26.

Just a guess, but maybe it's because I sent two emails on that thread very close together: first the email with the v50 patches then a reply to something else. If you look at the whole thread you can see that second reply came in later.
@JelteF
Copy link
Collaborator

JelteF commented Mar 22, 2025

I'm not sure what happened here. But this seems to be resolved now. Because the entry now has the v50 patch listed: https://commitfest.postgresql.org/patch/5660/

Looking at the merge commit it even seems like that was more than 36 hours ago, so way before you opened this issue.

Image

@pjungwir
Copy link
Author

I still see a v49. You're right that "Stats (from CFBot)" shows "v50", and the green checkmarks look like v50, but the "Latest attachment" at the bottom shows the v49 patch file:

Image

@JelteF JelteF added the bug Something isn't working label Mar 22, 2025
@JelteF
Copy link
Collaborator

JelteF commented Mar 22, 2025

Hmm, yeah that indeed seems like a bug then. Looking quickly at the code in question, I'm not sure why it missed this attachment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjungwir @JelteF