Skip to content

Jelte's not-yet-deployed commits #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Jelte's not-yet-deployed commits #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2796367
CFbot integration
JelteF Jan 12, 2025
8e33e1e
Integrate previous CFbot links with new code
JelteF Jan 12, 2025
6a96e78
Make CFbot add a history item when patch needs rebase
JelteF Jan 12, 2025
a9f9a19
Add a basic editorconfig file
JelteF Jan 12, 2025
df8c7a3
Add ID column to commitfest page
JelteF Jan 12, 2025
199bc75
Make sorting a toggle
JelteF Jan 13, 2025
057dad4
Allow sorting by name
JelteF Jan 13, 2025
7e10ee3
Allow sorting using the header of the closed patches too
JelteF Jan 13, 2025
d54c83a
Update readme with correct django version
JelteF Jan 13, 2025
013eeb1
Make /patch/{id} the URL for a patch
JelteF Jan 12, 2025
f660a47
Adjust direction of dropdowns at the bottom of the page (#4)
polkerty Jan 20, 2025
4e86587
Add dummy data for development (#5)
polkerty Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add ID column to commitfest page 
The ID of a CF entry is the only stable identifier (people can change
the name). That's why tooling such as CFbot uses the ID of the patch for
a lot of things (including showing it on the cfbot overview page).
Having it visible on the page is quite useful for debugging purposes

In eee60a5 the ID was added to the title of the entry, but that made the
the title of the page itself less prominent. So this is an attempt to
have the information available, but not too prominently visible.
  • Loading branch information
@JelteF
JelteF committed Jan 14, 2025
commit df8c7a30b2751fea58d070715df189dd77247cd1
2 changes: 2 additions & 0 deletions pgcommitfest/commitfest/templates/commitfest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
<thead>
<tr>
<th>{%if p.is_open%}<a href="#" style="color:#333333;" onclick="return sortpatches(0);">Patch</a>{%if sortkey == 0%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%endif%}{%endif%}</th>
<th>{%if p.is_open%}<a href="#" style="color:#333333;" onclick="return sortpatches(4);">ID</a>{%if sortkey == 4%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%endif%}{%else%}ID{%endif%}</th>
<th>Status</th>
<th>Ver</th>
<th>CI status</th>
Expand All @@ -85,6 +86,7 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
{%endif%}
<tr>
<td><a href="{{p.id}}/">{{p.name}}</a></td>
<td>{{p.id}}</td>
<td><span class="label label-{{p.status|patchstatuslabel}}">{{p.status|patchstatusstring}}</span></td>
<td>{%if p.targetversion%}<span class="label label-default">{{p.targetversion}}</span>{%endif%}</td>
<td class="cfbot-summary">
Expand Down
2 changes: 2 additions & 0 deletions pgcommitfest/commitfest/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ def commitfest(request, cfid):
orderby_str = 'lastmail, created'
elif sortkey == 3:
orderby_str = 'num_cfs DESC, modified, created'
elif sortkey == 4:
orderby_str = 'p.id'
else:
orderby_str = 'p.id'
sortkey = 0
Expand Down