Handle fsync failures in pg_receivewal and pg_recvlogical

petere · petere · commit 1e2fddfa33d3 · 2019-07-29T07:54:57.000+02:00
It is not safe to simply report an fsync error and continue. We must exit the program instead. Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Sehrope Sarkuni <sehrope@jackdb.com> Discussion: https://www.postgresql.org/message-id/flat/9b49fe44-8f3e-eca9-5914-29e9e99030bf@2ndquadrant.com
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -192,8 +192,8 @@ OutputFsync(TimestampTz now)
 
 	if (fsync(outfd) != 0)
 	{
-		pg_log_error("could not fsync file \"%s\": %m", outfile);
-		return false;
+		pg_log_fatal("could not fsync file \"%s\": %m", outfile);
+		exit(1);
 	}
 
 	return true;
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -134,10 +134,10 @@ open_walfile(StreamCtl *stream, XLogRecPtr startpoint)
 			/* fsync file in case of a previous crash */
 			if (stream->walmethod->sync(f) != 0)
 			{
-				pg_log_error("could not fsync existing write-ahead log file \"%s\": %s",
+				pg_log_fatal("could not fsync existing write-ahead log file \"%s\": %s",
 							 fn, stream->walmethod->getlasterror());
 				stream->walmethod->close(f, CLOSE_UNLINK);
-				return false;
+				exit(1);
 			}
 
 			walfile = f;
@@ -763,9 +763,9 @@ HandleCopyStream(PGconn *conn, StreamCtl *stream,
 		{
 			if (stream->walmethod->sync(walfile) != 0)
 			{
-				pg_log_error("could not fsync file \"%s\": %s",
+				pg_log_fatal("could not fsync file \"%s\": %s",
 							 current_walfile_name, stream->walmethod->getlasterror());
-				goto error;
+				exit(1);
 			}
 			lastFlushPosition = blockpos;
 
@@ -1015,9 +1015,9 @@ ProcessKeepaliveMsg(PGconn *conn, StreamCtl *stream, char *copybuf, int len,
 			 */
 			if (stream->walmethod->sync(walfile) != 0)
 			{
-				pg_log_error("could not fsync file \"%s\": %s",
+				pg_log_fatal("could not fsync file \"%s\": %s",
 							 current_walfile_name, stream->walmethod->getlasterror());
-				return false;
+				exit(1);
 			}
 			lastFlushPosition = blockpos;
 		}
diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c
@@ -864,7 +864,7 @@ tar_close(Walfile f, WalCloseMethod method)
 
 	/* Always fsync on close, so the padding gets fsynced */
 	if (tar_sync(f) < 0)
-		return -1;
+		exit(1);
 
 	/* Clean up and done */
 	pg_free(tf->pathname);

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,8 @@ OutputFsync(TimestampTz now)`
`192`	`192`
`193`	`193`	`if (fsync(outfd) != 0)`
`194`	`194`	`{`
`195`		`- pg_log_error("could not fsync file \"%s\": %m", outfile);`
`196`		`- return false;`
	`195`	`+ pg_log_fatal("could not fsync file \"%s\": %m", outfile);`
	`196`	`+ exit(1);`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -134,10 +134,10 @@ open_walfile(StreamCtl *stream, XLogRecPtr startpoint)`
`134`	`134`	`/* fsync file in case of a previous crash */`
`135`	`135`	`if (stream->walmethod->sync(f) != 0)`
`136`	`136`	`{`
`137`		`- pg_log_error("could not fsync existing write-ahead log file \"%s\": %s",`
	`137`	`+ pg_log_fatal("could not fsync existing write-ahead log file \"%s\": %s",`
`138`	`138`	`fn, stream->walmethod->getlasterror());`
`139`	`139`	`stream->walmethod->close(f, CLOSE_UNLINK);`
`140`		`- return false;`
	`140`	`+ exit(1);`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`walfile = f;`
`@@ -763,9 +763,9 @@ HandleCopyStream(PGconn conn, StreamCtl stream,`
`763`	`763`	`{`
`764`	`764`	`if (stream->walmethod->sync(walfile) != 0)`
`765`	`765`	`{`
`766`		`- pg_log_error("could not fsync file \"%s\": %s",`
	`766`	`+ pg_log_fatal("could not fsync file \"%s\": %s",`
`767`	`767`	`current_walfile_name, stream->walmethod->getlasterror());`
`768`		`- goto error;`
	`768`	`+ exit(1);`
`769`	`769`	`}`
`770`	`770`	`lastFlushPosition = blockpos;`
`771`	`771`
`@@ -1015,9 +1015,9 @@ ProcessKeepaliveMsg(PGconn conn, StreamCtl stream, char *copybuf, int len,`
`1015`	`1015`	`*/`
`1016`	`1016`	`if (stream->walmethod->sync(walfile) != 0)`
`1017`	`1017`	`{`
`1018`		`- pg_log_error("could not fsync file \"%s\": %s",`
	`1018`	`+ pg_log_fatal("could not fsync file \"%s\": %s",`
`1019`	`1019`	`current_walfile_name, stream->walmethod->getlasterror());`
`1020`		`- return false;`
	`1020`	`+ exit(1);`
`1021`	`1021`	`}`
`1022`	`1022`	`lastFlushPosition = blockpos;`
`1023`	`1023`	`}`