Don't run recover crash_temp_files test in Windows perl

adunstan · adunstan · commit ef823873840c · 2021-03-21T15:12:03.000-04:00
This reverts commit 677271a. "Unbreak recovery test on Windows" The test hangs on Windows, and attempts to remedy the problem have proved fragile at best. So we simply disable the test on Windows perl. (Msys perl seems perfectly happy). Discussion: https://postgr.es/m/5b748470-7335-5439-e876-6a88c951e1c5@dunslane.net
diff --git a/src/test/recovery/t/022_crash_temp_files.pl b/src/test/recovery/t/022_crash_temp_files.pl
@@ -6,7 +6,15 @@
 use Test::More;
 use Config;
 
-plan tests => 9;
+if ($Config{osname} eq 'MSWin32')
+{
+	plan skip_all => 'tests hang on Windows';
+	exit;
+}
+else
+{
+	plan tests => 9;
+}
 
 
 # To avoid hanging while expecting some specific input from a psql
@@ -124,10 +132,8 @@ BEGIN
 my $ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
 is($ret, 0, 'killed process with KILL');
 
-# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
-$killme_stdin .= "\\q\n";
+# Close psql session
 $killme->finish;
-$killme_stdin2 .= "\\q\n";
 $killme2->finish;
 
 # Wait till server restarts
@@ -214,10 +220,8 @@ BEGIN
 $ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
 is($ret, 0, 'killed process with KILL');
 
-# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
-$killme_stdin .= "\\q\n";
+# Close psql session
 $killme->finish;
-$killme_stdin2 .= "\\q\n";
 $killme2->finish;
 
 # Wait till server restarts
