Skip to content

Check for plugins better #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Check for plugins better #1039

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba035a5
Check for plugins better
levkk Oct 2, 2023
0347922
Move
levkk Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check for plugins better
  • Loading branch information
@levkk
levkk committed Oct 2, 2023
commit ba035a5439af47b79eb459b95dd9c97562fb279e
2 changes: 1 addition & 1 deletion pgml-apps/cargo-pgml-components/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pgml-apps/cargo-pgml-components/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "cargo-pgml-components"
version = "0.1.16"
version = "0.1.17"
edition = "2021"
authors = ["PostgresML <team@postgresml.org>"]
license = "MIT"
Expand Down
3 changes: 1 addition & 2 deletions pgml-apps/cargo-pgml-components/src/frontend/nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env bash
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" # This loads nvm bash_completion

${@}
exec ${@}
6 changes: 3 additions & 3 deletions pgml-apps/cargo-pgml-components/src/frontend/tools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ pub fn install() {

for plugin in ROLLUP_PLUGINS {
if execute_with_nvm(
Command::new("rollup")
.arg("-p")
Command::new("npm")
.arg("list")
.arg("-g")
.arg(plugin)
.arg("--version"),
)
.is_err()
{
Expand Down