Skip to content

validate: incorrect recovery target handling #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsmolk opened this issue Aug 1, 2019 · 1 comment
Closed

validate: incorrect recovery target handling #104

gsmolk opened this issue Aug 1, 2019 · 1 comment
Labels
bug fixed
Milestone
2.2.1

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Aug 1, 2019 •
edited
Loading

  1. The validate command fallback to validate all strategy, if --recovery-target-lsn is used.
  2. --recovery-target-time chooses wrong backup as restore candidate:
pg_probackup validate --instance node --time='2021-07-27 04:26:41+03'
LOG: Validate begin.
ERROR: Backup PVF8L2 has status: ERROR

pg_probackup show                                                         

BACKUP INSTANCE 'node'
================================================================================================================================
 Instance  Version  ID      Recovery Time           Mode  WAL      Current/Parent TLI  Time  Data  Start LSN   Stop LSN  Status 
================================================================================================================================
 node      10       PVF8L2  ----                    FULL  ARCHIVE  1 / 0                 3s  ----  0/6000028        0/0  ERROR  
 node      ----     PVF8KX  ----                    FULL  ARCHIVE  0 / 0                 0s  ----        0/0        0/0  ERROR  
 node      ----     PVF8IW  ----                    FULL  ARCHIVE  0 / 0                 0s  ----        0/0        0/0  ERROR  
 node      ----     PVF8IL  ----                    FULL  ARCHIVE  0 / 0                 0s  ----        0/0        0/0  ERROR  
 node      10       PVA1CA  2019-07-27 04:26:41+03  FULL  ARCHIVE  1 / 0                 9s  23MB  0/2000028  0/2000160  OK
@gsmolk gsmolk added the bug label Aug 1, 2019
@gsmolk gsmolk added this to the 2.1.6 milestone Aug 2, 2019
gsmolk added a commit that referenced this issue Aug 6, 2019
@gsmolk
[Issue #104] allow LSN as recovery target for validation if backup ID…
6da6318 
… is not specified
gsmolk added a commit that referenced this issue Aug 6, 2019
@gsmolk
[Issue #104] consider only OK and DONE backups as candidates for PITR…
3cc9d81 
… validation if backup ID is not specified
@gsmolk
Copy link
Contributor Author

gsmolk commented Aug 6, 2019

Fixed, merged to master.
Reported by Alexey Shishkin

@gsmolk gsmolk modified the milestones: 2.1.6, 2.2.0 Aug 9, 2019
@gsmolk gsmolk added the fixed label Sep 18, 2019
@gsmolk gsmolk closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
1 participant
@gsmolk