Move all inlined compatible wrappers into header file #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation segregated compatible inline function wrappers into separate .c file that prevented inlining of these functions into caller points in other modules. In current patch all these fuctions with `static inline` specification have been moved to header file compat.h. This emulates behavior of macro expanding in case when compiler performs inlining. Resolve postgrespro#45
be05cc6 to
8ac2e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation segregated compatible inline function wrappers into separate .c file that prevented inlining of these functions into caller points in other modules. In current patch all these fuctions are moved to header file
compat.hso that inlining works.Resolve #45