Skip to content

Run the archive command through exec #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Run the archive command through exec #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c4b89c
Run the archive command through exec
asavchkov Mar 6, 2024
2a3901e
Invoke exec only on Linux
asavchkov Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion testgres/plugins/pg_probackup2/pg_probackup2/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,11 @@ def set_archiving(
if custom_archive_command is None:
archive_command = " ".join([f'"{init_params.probackup_path}"',
'archive-push', *self.backup_dir.pb_args])
if os.name == "nt":
if os.name == 'posix':
# Dash produces a core dump when it gets a SIGQUIT from its
# child process so replace the shell with pg_probackup
archive_command = 'exec ' + archive_command
elif os.name == "nt":
archive_command = archive_command.replace("\\", "\\\\")
archive_command += f' --instance={instance}'

Expand Down