Skip to content

OsOperations.isdir is added #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024
Merged

OsOperations.isdir is added #166

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f3fc40
OsOperations.isdir is added
dmitry-lipetsk Dec 18, 2024
9f52743
Tests for LocalOperations methods isdir and isfile are added
dmitry-lipetsk Dec 18, 2024
38ce127
Tests for RemoteOperations methods isdir and isfile are updated
dmitry-lipetsk Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
OsOperations.isdir is added 
It a correction of base interface - OsOperations.

It seems we forgot to add a declaration of the "abstract" method "isdir".
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Dec 18, 2024
commit 2f3fc40d39562ffa62e77863df8316becd353dee
3 changes: 3 additions & 0 deletions testgres/operations/os_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ def read_binary(self, filename, start_pos):
def isfile(self, remote_file):
raise NotImplementedError()

def isdir(self, dirname):
raise NotImplementedError()

def get_file_size(self, filename):
raise NotImplementedError()

Expand Down