Skip to content

PostgresNode::pid is improved #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 1, 2025
Merged

PostgresNode::pid is improved #199

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b5c4d7b
PostgresNode::pid is improved
dmitry-lipetsk Feb 27, 2025
fce595a
PostgresNode::pid is updated
dmitry-lipetsk Feb 27, 2025
0aebc00
Merge branch 'master' into D20250227_001--node-pid
dmitry-lipetsk Feb 28, 2025
0863cf5
execute_utility2 is updated (ignore_errors)
dmitry-lipetsk Feb 28, 2025
a4e65bf
Merge branch 'D20250228_001--execute_utility2' into D20250227_001--no…
dmitry-lipetsk Feb 28, 2025
09976ae
PostgresNode::_try_shutdown is rewrited (normalization)
dmitry-lipetsk Feb 28, 2025
ab28c2e
Merge branch '20250228_002--try_shutdown' into D20250227_001--node-pid
dmitry-lipetsk Feb 28, 2025
0402c4a
PostgresNode::pid uses the data from "pg_ctl status" output.
dmitry-lipetsk Feb 28, 2025
45d2b17
PostgresNode::_try_shutdown is correct (return None)
dmitry-lipetsk Feb 28, 2025
a960ac7
Merge branch '20250228_002--try_shutdown' into D20250227_001--node-pid
dmitry-lipetsk Feb 28, 2025
82981f5
Merge branch 'master' into D20250227_001--node-pid
dmitry-lipetsk Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PostgresNode::_try_shutdown is correct (return None) 
This method returns nothing (None).
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Feb 28, 2025
commit 45d2b176dc618156312639e41f09c27473266a1f
2 changes: 1 addition & 1 deletion testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def _try_shutdown(self, max_attempts, with_force=False):

# If force stopping is enabled and PID is valid
if not with_force:
return False
return

node_pid = self.pid
assert node_pid is not None
Expand Down