Skip to content

Remove usage of not standard nc in remote_ops.py is_port_free #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 16, 2025
Merged

Remove usage of not standard nc in remote_ops.py is_port_free #284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
078483f
Remove usage of not standard nc in remote_ops.py is_port_free
Aug 6, 2025
cb0d9fb
Fix for flake8 checks [remote_ops.py]
dmitry-lipetsk Aug 7, 2025
dca1f74
Remove usage of not standard nc in remote_ops.py is_port_free
Aug 6, 2025
753bdb0
[flake8] One more time
dmitry-lipetsk Aug 15, 2025
7654478
RemoteOperations::is_port_free uses a regexp, tcp6 is removed
dmitry-lipetsk Aug 15, 2025
1c675f0
debug: is_port_free requires number in range [0..65535]
dmitry-lipetsk Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
debug: is_port_free requires number in range [0..65535]
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Aug 15, 2025
commit 1c675f008cf205caf4c576b75e469905e2fae45c
2 changes: 2 additions & 0 deletions testgres/operations/local_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,8 @@ def get_process_children(self, pid):

def is_port_free(self, number: int) -> bool:
assert type(number) == int # noqa: E721
assert number >= 0
assert number <= 65535 # OK?

with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
try:
Expand Down
2 changes: 2 additions & 0 deletions testgres/operations/remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,8 @@ def get_process_children(self, pid):

def is_port_free(self, number: int) -> bool:
assert type(number) == int # noqa: E721
assert number >= 0
assert number <= 65535 # OK?

# grep -q returns 0 if a listening socket on that port is found
port_hex = format(number, '04X')
Expand Down