Skip to content

Minify JS within <script type="module"> #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2021
Merged

Minify JS within <script type="module"> #135

merged 2 commits into from
Apr 8, 2021

Conversation

Scrum
Copy link
Member

@Scrum Scrum commented Apr 6, 2021

No description provided.

@Scrum Scrum requested a review from maltsev April 6, 2021 06:34
SukkaW
SukkaW reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a reviewer, but FWIW the PR LGTM.

@Scrum
Copy link
Member Author

Scrum commented Apr 8, 2021

@maltsev ping

@maltsev maltsev changed the title Milestone 0.2.9 Minify JS within <script type="module"> Apr 8, 2021
maltsev
maltsev approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@maltsev maltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maltsev
Copy link
Member

maltsev commented Apr 8, 2021

@Scrum thanks for implementing it! I just renamed the PR name, so it better reflects the changes made.

For reference: this is related to issue #134

@maltsev maltsev merged commit ce0f119 into master Apr 8, 2021
@maltsev maltsev deleted the milestone-0.2.9 branch April 8, 2021 15:47
@maltsev maltsev mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltsev maltsev maltsev approved these changes

+1 more reviewer

@SukkaW SukkaW SukkaW left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scrum @maltsev @SukkaW