allow delimeter specification #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrum
reviewed
Oct 19, 2020
Scrum
requested changes
Oct 19, 2020
lib/index.js
Outdated
| @@ -21,6 +21,7 @@ module.exports = (options = {}) => { | |||
| let subtree; | |||
| let source; | |||
| let locals = false; | |||
| const delimiters = options.delimiters || ['{{', '}}']; | |||
There was a problem hiding this comment.
I think it's worth creating a separate settings object for posthtml-expressions
const posthtmlExpressionsOptions = {
locals: false
}Pay attention to the locale, it will be necessary to override the used local variable locals to the link to the options object posthtmlExpressionsOptions.locals
if (options.delimiters) {
posthtmlExpressionsOptions.delimiters = options.delimiters
}so we will be sure that nothing will break if u posthtml-expressions the default value will change delimiters
There was a problem hiding this comment.
@Scrum updated. How does this look now?
753454e to
4bcb79b
Compare
Scrum
approved these changes
Nov 5, 2020
|
@deiay publish v1.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posthtml-include uses posthtml-expressions to detect local variables passed into include blocks. The default variable syntax for posthtml-expressions is {{ my_variable }}. However, many JavaScript frameworks use
{{and}}as expression delimiters for their own uses which would clash with posthtml-expression's variable injection. posthtml-expressions allows for the configuartion of variable delimiters to solve this.This change allows for the passing in of a delimiter option that will get passed to posthtml-expressions. This lets us change the delimter that's used for variables in out includes.