Skip to content

Decrease package size from 43.6 kB to 11.1 kB #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Decrease package size from 43.6 kB to 11.1 kB #85

wants to merge 1 commit into from

Conversation

shoonia
Copy link
Contributor

@shoonia shoonia commented Jan 10, 2022

Filter all development files from npm package.

npm pack --dry-run

from:

=== Tarball Contents ===
119B   .clintonrc.json
336B   .editorconfig
639B   .github/funding.yml
785B   .github/workflows/nodejs.yml
116B   .huskyrc
19B    .lintstagedrc
122B   ava.config.js
20.4kB changelog.md
504B   dist/chunk.T6SARJYH.js
819B   dist/index.d.ts
2.1kB  dist/index.js
384B   dist/location-tracker.d.ts
173B   dist/location-tracker.js
1.1kB  license
1.6kB  package.json
4.4kB  readme.md
9.6kB  test/test-core.spec.ts
176B   tsconfig.json
227B   xo.config.js
=== Tarball Details ===
package size:  11.9 kB
unpacked size: 43.6 kB
total files:   20

to:

=== Tarball Contents ===
504B  dist/chunk.T6SARJYH.js
819B  dist/index.d.ts
2.1kB dist/index.js
384B  dist/location-tracker.d.ts
173B  dist/location-tracker.js
1.1kB license
1.6kB package.json
4.4kB readme.md
=== Tarball Details ===
package size:  4.6 kB
unpacked size: 11.1 kB
total files:   8

Scrum
Scrum requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@Scrum Scrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/posthtml/posthtml-parser/runs/4837109731?check_suite_focus=true

@shoonia shoonia mentioned this pull request Jan 17, 2022
Merged
@shoonia
Copy link
Contributor Author

shoonia commented Jan 17, 2022

I opened a new PR with the fixed version. I don't understand how I can restore my fork and update this PR one, then I open a new one. #87

@shoonia shoonia closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrum Scrum Scrum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoonia @Scrum