Skip to content

Alarm Clock Program #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

pratimakush10
Copy link
Contributor

@pratimakush10 pratimakush10 commented Jun 10, 2021

Title: Alarm Clock Program

LGM-SOC'21 Participant

Closes: #75

Description : This script is the basic alarm clock using time module of Python.
when you input hours and minutes for alarm to ring at that respective time alarm will ring

Type of change
What sort of change have you made:
👍 New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:
👍 My code follows the guidelines of this project.
👍 I have performed a self-review of my own code.
👍 I have commented my code, particularly where ever it was hard to understand.
I have made corresponding changes to the documentation.
👍
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
Any dependent changes have been merged and published in downstream modules.

Screenshots

Screenshot

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your issue number is #75. Do the change. Always you should the issue number that you got yourself assigned to.
You PR doesn't follow the template. Check for the PR template in README file of the project.
Follow the right project structure. Always have a good glance of README for guidelines before you create an issue or PR.
You project folder name should be "Alarm Clock"
The file name of readme file should be README.md
Screenshots and Images should be in "Images" folder.
The file name to add requirements should be "requirements.txt" file
Add libraries used in this project and any other requirements in "requirements.txt" file.
Steps you had mentioned it in 'requirements' file should come in README.md file of your project.
You also have a template to follow for your README.md file. It's mentioned in the README file of the project.

Kindly do the needful changes. @pratimakush10

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot you added should be in "Images" folder.
It's in Image folder. Do this change. @pratimakush10

@prathimacode-hub
Copy link
Owner

Thanks for rectifying the changes. Official labels had come out. I would merget this PR with the labels once I clarify about it. So you are good to take up a new issue to work on. You had done an amazing work.✔✨ @pratimakush10

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 10, 2021
@pratimakush10
Copy link
Contributor Author

ok ma'am
Thank you

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. @pratimakush10

@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 11, 2021
@prathimacode-hub prathimacode-hub merged commit 179b934 into prathimacode-hub:main Jun 11, 2021
@pratimakush10 pratimakush10 mentioned this pull request Jun 11, 2021
@prathimacode-hub prathimacode-hub added 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 and removed 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. labels Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alarm_Clock
2 participants