Add CSS/HTML syntax highlighting in tagged template strings #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eade676 to
fc3043b
Compare
This commit adds syntax highlighting in `` css`...` `` and `` html`...` `` tagged template strings.
fc3043b to
02e7524
Compare
|
Getting really complex. Never expected template syntax highlighting to get to this level 😂 |
|
Indeed. |
|
v1.2.0 shouldn't have been released before wbond/package_control_channel#9127 is merged. This will probably break syntax highlighting for those still using ST4152..4179. |
|
My bad. I woke up and deleted the release and tag but apparently it was picked up half an hour ago. Would people simply fail to upgrade? |
|
Looks like PC picked up the change. Hopefully if someone did picked up 1.2 but shouldn't, they could just fix it by re-installing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syntax highlighting in
css`...`andhtml`...`tagged template strings.It requires CSS syntax of ST4180+ and is therefore not compatible with earlier builds.
It also fixes an issue with
{{ ... }}not being properly detected in more recent ST builds.A related core fix sublimehq/Packages#4055 is deployed with ST4193+.
Most important parts are backported to CSS (for Ngx) syntax to maintain compatibility with ST4180.