Linux support #237
Linux support #237
Conversation
…x 64bit (I do not have the binary right now). Therefore sound currently doesn't work for linux.
|
@antiboredom do you have the ffmpeg lib with mp3 codecs etc. for linux (and nw.js 12.3)? |
| @@ -16,13 +16,15 @@ var info = require('./package.json'); | |||
| var request = require('request'); | |||
|
|
|||
| var isWin = process.platform.indexOf('win') > -1; | |||
| var isMac = process.platform.indexOf('darwin') > -1; | |||
| var isLinux = process.platform.indexOf('linux') > -1; | |||
There was a problem hiding this comment.
Would you be open to switching these lines to the same logic as https://github.com/davejm/p5.js-editor/blob/a340cf90835b15b7097a545c3ec28b67f7e8fab3/public/index.html#L41-L43 ?
There was a problem hiding this comment.
@jedahan Yes definitely. I was just following the logic for the respective files. Do you think the other logic is cleaner/clearer?
|
After reading https://nodejs.org/api/process.html#process_process_platform , I think I most prefer the simplicity of var isWin = process.platform === 'win32';
var isMac = process.platform === 'darwin';
var isLinux = process.platform === 'linux';Honestly this is nitpicking at this point, and would love to see this merged sooner than later :) |
|
@jedahan yes that is cleaner. I had looked at that api page as well but assumed from the regexes that the method could return -32 and -64 variants but it seems not so I'll change it. |
Adds support for running and building for Linux 64bit.
Note that boilerplate comments are set up in the gulpfile to copy a custom build ffmpeg library for Linux into the dist, however, I don't have this at the moment so sound doesn't work. Making it work would be a matter of getting the custom libffmpegsumo.so library built for Linux 64bit with the relevant codec support, putting it in ./lib and uncommenting the code in gulpfile for copying the linux library.