Add EmptyHttpRequest Indexer #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eesquibel
reviewed
Apr 30, 2025
| @@ -172,6 +172,7 @@ public EmptyHttpRequest (HttpRequestBase originalRequest) | |||
| public override string ContentType { get { return _originalRequest.ContentType; } set { } } | |||
| public override System.Text.Encoding ContentEncoding { get { return _originalRequest.ContentEncoding; } set { } } | |||
| public override RequestContext RequestContext { get; set; } | |||
| public override string this[string key] => QueryString[key] ?? Form[key] ?? Cookies[key]?.Value ?? ServerVariables[key]; | |||
There was a problem hiding this comment.
Or you could also
Suggested change
| public override string this[string key] => QueryString[key] ?? Form[key] ?? Cookies[key]?.Value ?? ServerVariables[key]; | |
| public override string this[string key] => _originalRequest[key]; |
There was a problem hiding this comment.
Yes, but I am not sure if/what EMPTYHttpRequest should return in the first place... I just don't want it to throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual indexer of the base class (HttpRequestBase) throws NotImplementedException.
This implementation follows the order of probing of the collection that is used in HttpRequest.