-
Notifications
You must be signed in to change notification settings - Fork 11
Add alias search fallback to character() #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's not vendored; feel free to change it |
When I ran |
Ah yeah, it's not deterministic |
Why is it an issue, though? You could make it generate to Though it probably makes sense to replace the built-in perfect-hash with the |
I didn't know it is not deterministic. I found db bugs here, so I will rewrite db part soon. |
ok, bug is fixed but still phf is not ported. |
rebase on master but still using phf crate |
Co-Authored-By: Dimitris Fasarakis Hilliard <d.f.hilliard@gmail.com>
@youknowone Looks like we're all done here. Am I forgetting anything? |
The feature is done. |
fix #11
Because I couldn't easily control the vendored generator, I used external phf crate for the last commit.
If you don't like it, it can be replaced by other stuff using first 3 commits which actually populating alias data.
cc @DimitrisJim