fix: client prompt return on context cancellation #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
reviewed
Feb 4, 2025
Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com>
Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com>
9e16398 to
9a59353
Compare
Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com>
Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com>
juliusmh
pushed a commit
to juliusmh/client_golang
that referenced
this pull request
Jun 30, 2025
* fix: client prompt return on context cancellation Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com> * test: add context cancellation unit test Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com> * fix/rid unused package Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com> * fix/lint and formatting Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com> --------- Signed-off-by: Umegbewe Nwebedu <nwebedujunior55@gmail.com>
Merged
1 task
1 task
1 task
1 task
1 task
1 task
Merged
1 task
Merged
1 task
1 task
1 task
This was referenced Jul 21, 2025
Merged
1 task
This was referenced Aug 11, 2025
Merged
1 task
1 task
1 task
This was referenced Aug 11, 2025
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the client blocks for the entire duration of the response stream, even when the provided context had already been canceled or times out
Relevant issue #1698