collectors/version: Allow custom additional labels #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c65de7 to
8d75511
Compare
d1379a0 to
76fa0f3
Compare
bwplotka
reviewed
Aug 26, 2025
Comment on lines
31
to
33
| // NewCollectorWithLabels returns a collector that exports metrics about current | ||
| // version information and allows to set additional custom labels. | ||
| func NewCollectorWithLabels(program string, labels prometheus.Labels) prometheus.Collector { |
There was a problem hiding this comment.
Wanna spend extra 10m and add proper options to this type? Will help in future changes (e.g. filtering some labels etc)
type Option func(*options)
type options struct {
extraConstLabels prometheus.Labels
}
func WithExtraConstLabels(l prometheus.Labels) Option {
return func(o *options) {
o.extraConstLabels = l
}
}
func NewCollector(program string, opts ...Option) prometheus.Collector {
o := option{}
for _, opt := range opts {
opt(&o)
}
//...
There was a problem hiding this comment.
Do you want me to rename the func to NewCollectorWithOptions then or should I add the opts arg to NewCollector?
There was a problem hiding this comment.
Ah, understood, it's a variadic function now.
43cf50a to
1439d34
Compare
|
@bwplotka Thanks for the suggestion, I applied you change. |
Co-Authored-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu>
1439d34 to
a8cbb1f
Compare
kakkoyun
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case here, where it would be nice to support custom labels in the build info: kubernetes/kube-state-metrics#2739
This would allow us adding labels to the build info metric exposed by the version collector, e.g. in this case the version of the kubernetes client library we're using.
This also adds some tests for the version collector.