Skip to content

Should use standart time.time instead of timeit.default_timer #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2017
Merged

Should use standart time.time instead of timeit.default_timer #175

merged 2 commits into from
Jul 6, 2017

Conversation

melnikk
Copy link
Contributor

@melnikk melnikk commented Jul 5, 2017

This is a rollback PR of #106 because of buggy timestamp results of timeit.default_timer.

@melnikk melnikk mentioned this pull request Jul 5, 2017
Merged
@brian-brazil
Copy link
Contributor

default_timer is behaving correctly, however the graphite bridge shouldn't be using it as it wants the actual unix time. Can you rollback just that bit?

@melnikk
Copy link
Contributor Author

melnikk commented Jul 6, 2017

done

@brian-brazil brian-brazil merged commit caf3293 into prometheus:master Jul 6, 2017
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melnikk @brian-brazil