Fix lint related to vertical whitespace #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves E123, E302, E303, E305, and E306.
tests/test_exposition.py
Outdated
| self.registry.register(MyCollector()) | ||
| self.assertEqual(b'# HELP nonnumber Non number\n# TYPE nonnumber untyped\nnonnumber 123.0\n', generate_latest(self.registry)) | ||
|
|
||
|
|
||
| class MyNumber(object): |
There was a problem hiding this comment.
I'd prefer to keep these where they are so it's clear what's going on.
There was a problem hiding this comment.
I think inlining helper classes to test methods is generally a bad idea as it pushes test authors to making bigger more complex methods to avoid duplicating components.
That said, have reversed the change and will push now.
As requested by @brian-brazil in review.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves E123, E302, E303, E305, and E306.