-
Notifications
You must be signed in to change notification settings - Fork 732
deprecation warning with Python 3.10 #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for bringing this to my attention! Given that we are still supporting Python 3.6, I think we need a wrapper (in There are various places where it's used: ./shortcuts/prompt.py
./shortcuts/dialogs.py
./shortcuts/progress_bar/base.py
./shortcuts/utils.py
./input/vt100.py
./input/win32.py
./history.py
./application/application.py
./contrib/telnet/server.py
./contrib/ssh/server.py
./eventloop/inputhook.py
./eventloop/async_generator.py
./eventloop/utils.py |
@jonathanslenders yes I am. This means updating the github actions as well right? |
Python 3.10 is no longer beta and this issue still exists, affecting all xonsh environments that use ptk. |
Any updates on this issue? A fresh install of Xonsh will emit this deprecation error on every command since Python 3.10 is now out. Instead of adding something to try:
from asyncio import get_running_loop
except ImportError:
from asyncio import get_event_loop as get_running_loop Or, you can add import asyncio
if not hasattr(asyncio, 'get_running_loop'):
asyncio.get_running_loop = asyncio.get_event_loop |
I opened a PR. See above. |
FYI, brew has now switched the xonsh recipe to Python 3.10, so this pops up all the time on any brew installed xonsh. Brew has migrated over 150 formula, and is migrating the other 450, so this will pop up on anything that moves to Python 3.10 and uses prompt-toolkit. |
Vote to close this issue. Can confirm that prompt-toolkit 3.0.22 works great in Xonsh on Python 3.10 with my merged PR. For Xonsh users, you can simply |
Python 3.10 is still beta. This is just a heads up. Here is the full warning
The text was updated successfully, but these errors were encountered: