NF: Automatic microphone polling #6843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6843 +/- ##
==========================================
- Coverage 49.59% 49.56% -0.03%
==========================================
Files 332 332
Lines 61349 61383 +34
==========================================
+ Hits 30424 30426 +2
- Misses 30925 30957 +32
|
|
Updated to allow polling continuously between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the microphone to poll asynchronously by getting samples using a background thread. When
autoPolling=True, the background thread will get samples at a rate specified bypollInterval. This value just needs to be less than the stream buffer size to prevent samples from being missed. Calls topoll()in existing scripts will still work as they always have. However, the user never actually needs to callpoll()explicitly whenautoPollingis enabled, as the stream buffer is effectively infinite and all data is contains will be automatically written to the recording buffer when the stream is stopped.This also has the benefit of keeping the audio stream alive if the device drivers tend to timeout and go into an inactive state.