ci: Add Ubuntu and Windows arm jobs #3651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
The turbo-rails failures are due to changes in Ruby head with the |
Do you have a link? Or is it broken and will be fixed? |
See below. |
|
I see, ruby/ruby#13074 had a bug but ruby/ruby#13185 will fix it. |
|
And the bug fix has finally landed in the GHA Ruby master builds. So, turbo-rails is now passing. |
|
Rebased to force a full CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GHA now supports arm64 runners on Ubuntu & Windows.
Added jobs for both.
Note that the Ubuntu jobs are affected by an unsigned vs signed char bug, probably in ragel, as the failures related to the c source code generated by it. I tried a few things, and got Ruby 2.7 passing, but the other versions failed. Gave up.
Disabled the 'PUMA_MAKE_WARNINGS_INTO_ERRORS=true' workflow step in the Ubuntu arm64 jobs, and the jobs passed...
Windows arm had issues with
TestPumaServertest_accept_emfile(retries & intermittent failures), added aPuma::IS_ARMconstant, add used it to add a small sleep for the test.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.