Allow generator to continue even if any errors encountered in fetch comparison #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling @carabasdaniel changes from github-changelog-generator#736
Successfully tested against stdlib module and generated the log file successfully
Test Setup
Gemfile: optional: ":development": - gem: github_changelog_generator git: https://github.com/carabasdaniel/github-changelog-generator ref: fb7ea37cdff79c22a662e99ac38a10c6d0a7a131 condition: Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.2.2')/Users/sheena/modulework/changelog/daniel/testing/puppetlabs-stdlib/vendor/gems/ruby/2.7.0/gems/faraday-http-cache-2.2.0/lib/faraday/http_cache.rb:102: warning: The called methodinitialize' is defined hereFound 81 tags
Fetching tags dates: 81/81
Sorting tags...
Received issues: 1190
Pull Request count: 1190
Filtered pull requests: 695
Fetching events for issues and PR: 695
Fetching closed dates for issues: 695/695
Warning: PR 1015 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 774 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 770 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 769 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 765 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 301 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 267 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 9 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Associating PRs with tags: 695/695
Generating entry...
Done!
Generated log placed in /Users/sheena/modulework/changelog/daniel/testing/puppetlabs-stdlib/CHANGELOG.md
➜ puppetlabs-stdlib git:(main) ✗ code CHANGELOG.md`