Skip to content

Export all types in React module #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2018
Merged

Export all types in React module #155

merged 1 commit into from
Aug 24, 2018

Conversation

tellnobody1
Copy link
Contributor

@tellnobody1 tellnobody1 commented Jul 5, 2018 •
edited
Loading

Some are types are not exported. For example:

ReactSpecAll
ReactSpecRequired
ReactSpecOptional
ReactSpecShouldComponentUpdate
GetSnapshotBeforeUpdate
ReactSpecUnsafe
ReactClassConstructor

They are need in other libraries (e.g. purescript-thermite) and for generic helpers.

Order of exports is changed according to appearance in code.

@tellnobody1
Copy link
Contributor Author

@ethul What do you think about this?
It's the reason we've forked the project and it's blocking a contribution to thermite.

@ethul
Copy link
Contributor

ethul commented Jul 22, 2018

Thanks for this PR. I don't immediately see an issue with exporting these types.

@natefaubion was there a specific reason we did not export these? Just want to confirm.

@sudhirvkumar
Copy link

@natefaubion @ethul any update on this PR?

@natefaubion
Copy link
Contributor

I'm fine with exporting these.

@ethul
Copy link
Contributor

ethul commented Aug 24, 2018

Sorry for the delay!

@ethul ethul merged commit e059deb into purescript-contrib:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tellnobody1 @ethul @sudhirvkumar @natefaubion