Skip to content

Use null for mempty ReactElement #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

Use null for mempty ReactElement #187

merged 2 commits into from
Jan 4, 2023

Conversation

natefaubion
Copy link
Contributor

@natefaubion natefaubion commented Jan 3, 2023 •
edited
Loading

Description of the change
This updates the Monoid/Semigroup instances of ReactElement to represent mempty as null rather than an empty fragment, which is more in line with API expectations for third-party libraries. Due to that, this can technically be considered a breaking change? However, this change is not observable within the exported purescript-react types and interface.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

JordanMartinez
JordanMartinez approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be publicized, so that people are aware of this change?

@natefaubion
Copy link
Contributor Author

I think it would be fine to just release it as a major version bump.

@natefaubion natefaubion merged commit cfb3d65 into purescript-contrib:main Jan 4, 2023
@natefaubion natefaubion deleted the nf/null-mempty branch January 4, 2023 18:03
@JordanMartinez JordanMartinez mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natefaubion @JordanMartinez