Skip to content

Add iotools functions for Meteonorm #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jul 15, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR adds functions for retrieving irradiance and weather data from Meteonorm. This is the last function I plan on contributing to the commercial iotools, as pvlib then will support what I consider the major providers of satellite-derived irradiance data.

Documentation:

@AdamRJensen AdamRJensen added this to the v0.13.1 milestone Jul 15, 2025
@AdamRJensen AdamRJensen added the io label Jul 15, 2025
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things here and there. Otherwise LGTM!

Specification of the hoirzon line. Can be either 'flat' or 'auto', or
specified as a list of 360 horizon elevation angles. The default is
'auto'.
terrain: string, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
terrain: string, optional
terrain: str, optional

with the same random seed will yield identical results.
clear_sky_radiation_model : {'esra', 'solis'}
Which clearsky model to use. The default is 'esra'.
data_version : string, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_version : string, optional
data_version : str, optional

data_version : string, optional
Version of Meteonorm climatological data to be used. The default is
'latest'.
future_scenario: string, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
future_scenario: string, optional
future_scenario: str, optional

'latest'.
future_scenario: string, optional
Future climate scenario.
future_year : integer, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
future_year : integer, optional
future_year : int, optional

where applicable. See variable :const:`VARIABLE_MAP`. The default is
True.
url: str, optional.
Base URL of the Meteonorm API. 'climate/tmy'` is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Base URL of the Meteonorm API. 'climate/tmy'` is
Base URL of the Meteonorm API. `'climate/tmy'` is

In decimal degrees, east is positive (ISO 19115).
api_key: str
Meteonorm API key.
parameters: list, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be list or 'all' (like the turbidity)?

(north=0, east=90, south=180, west=270). The default is 180.
time_step: {'1min', '1h'}, optional
Frequency of the time series. The default is '1h'.
horizon: optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
horizon: optional
horizon: str, optional

time_step : {'1min', '15min', '1h'}, optional
Frequency of the time series. The parameter is ignored when requesting
forcasting data. The default is '15min'.
horizon : optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
horizon : optional
horizon : str, optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants