Skip to content
This repository was archived by the owner on Nov 4, 2020. It is now read-only.

Adding pagination to Gitlab.getProjects #18

Merged
merged 1 commit into from
Sep 14, 2013
Merged

Adding pagination to Gitlab.getProjects #18

merged 1 commit into from
Sep 14, 2013

Conversation

samrocketman
Copy link
Contributor

It doesn't currently exist. I ran into a wall head long and it took a while to debug and figure out the cause. I thought returning only 20 projects was too perfect of a number and it turns out it was. The API supports pagination so I'm adding it to your getProjects call.

@samrocketman
Copy link
Contributor Author

@Itxaka although I haven't tested it yet I imagine that Gitlab.getUsers and Gitlab.getGroups needs pagination as well. I'll test that next week and update this merge request. I'll need pagination going forward because my gitlab-mirrors project will be designed to handle many groups and users (greater than 100 which is max supported items per page).

Here is an example of how I'm currently handling it with my fork of your project.

@Itxaka
Copy link
Member

Itxaka commented Sep 14, 2013

@SAG47 Yep, it needs pagination as well. Let's see if I got some time this afternoon to code it :D

Thanks for all the patches man ;)

Itxaka added a commit that referenced this pull request Sep 14, 2013
Adding pagination to Gitlab.getProjects
@Itxaka Itxaka merged commit 7c3756b into pyapi-gitlab:master Sep 14, 2013
@samrocketman samrocketman deleted the feature-pagination branch September 14, 2013 16:49
@samrocketman samrocketman restored the feature-pagination branch September 14, 2013 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants