This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Fix modbt scan response adv data length #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although advertising packets are limited to 31 bytes, certain advertising peripherals allow for an additional “scan response” of more data. The ble_adv data bytes should use dynamic sizing via sizeof instead of static ESP_BLE_ADV_DATA_LEN_MAX. More information is documented at a nearly identical issue: espressif/esp-idf#369
peter-pycom
added a commit
that referenced
this pull request
May 4, 2020
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
…onse-data-length-sizeof Fix modbt scan response adv data length
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although advertising packets are limited to 31 bytes, certain advertising peripherals allow for an additional “scan response” of more data. The ble_adv data bytes should use dynamic sizing via sizeof instead of static ESP_BLE_ADV_DATA_LEN_MAX.
More information is documented at a nearly identical issue: espressif/esp-idf#369
Pycom forum discussion at: https://forum.pycom.io/topic/2460/ble-features-non-blocking-connects-char-presentation-format