Deploying pydantic-docs with    Cloudflare Pages

View logs

CodSpeed Performance Report

Merging #10313 will not alter performance

_{Comparing dc-defer-build (7ae6da8) with main (59a3de7)}

Summary

✅ 49 untouched benchmarks

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
dataclasses.py
pydantic/_internal
_dataclasses.py
_model_construction.py
Project Total

This report was generated by python-coverage-comment-action

So the reason why the added _force_build argument was required is because currently ultimately, rebuild_dataclass calls complete_dataclass. Because the configuration can come from both the decorator or the __pydantic_config__ attribute, complete_dataclass sets cls.__pydantic_config__:

So that the following works as expected:

@pydantic_dataclass(config={'strict': True})
class DC:
    a: int

assert DC.__pydantic_config__ == {'strict': True}

If in rebuild_dataclass, we pass a new config object, as done currently here:

The following will happen:

@pydantic_dataclass
class DC:
    __pydantic_config__ = {'defer_build': True}  # or as a decorator parameter, doesn't matter

assert DC.__pydantic_config__ == {'defer_build': True}
rebuild_dataclass(DC)
assert DC.__pydantic_config__ == {'defer_build': True}  # AssertionError, `'defer_build'` is now set to `False`

And is inconsistent with the BaseModel behavior. Besides, I think the config dict on models and dataclasses shouldn't change after the class is defined, no matter if a rebuild was performed or not (and this is what's causing issues with TypeAdapter failing tests I think).

And is inconsistent with the BaseModel behavior. Besides, I think the config dict on models and dataclasses shouldn't change after the class is defined, no matter if a rebuild was performed or not (and this is what's causing issues with TypeAdapter failing tests I think).

I see, makes sense. Let's revert back then to use the _force_build flag. Apologies for the back and forth on the diff.