Skip to content

Cleanly defer_build on TypeAdapters, removing experimental flag #10329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Sep 5, 2024

cc @MarkusSintonen, this will be included in v2.10 🚀.

cc @Viicos, I think we could merge this + rebase against your current PR (github.com//pull/10313) to make the tests more simple on that front.

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 5, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 5, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4857099
Status: ✅  Deploy successful!
Preview URL: https://26a76d2f.pydantic-docs.pages.dev
Branch Preview URL: https://no-experimental-defer-build.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed relnotes-fix Used for bugfixes. labels Sep 5, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #10329 will not alter performance

Comparing no-experimental-defer-build (4857099) with main (97d357f)

Summary

✅ 50 untouched benchmarks

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runkle sydney-runkle requested a review from Viicos September 6, 2024 07:55
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above otherwise looks good!

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runkle sydney-runkle enabled auto-merge (squash) September 6, 2024 12:03
@sydney-runkle sydney-runkle merged commit e060425 into main Sep 6, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the no-experimental-defer-build branch September 6, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants