Skip to content

Fix evaluation of stringified annotations during namespace inspection #10347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

Fix evaluation of stringified annotations during namespace inspection #10347

merged 1 commit into from
Sep 7, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 6, 2024

Change Summary

Fixes #10345

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 6, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 924d54c
Status: ✅  Deploy successful!
Preview URL: https://192a5a64.pydantic-docs.pages.dev
Branch Preview URL: https://10345.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the 10345 branch 2 times, most recently from 438128c to 3e11754 Compare September 7, 2024 13:32
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 7, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10347 will not alter performance

Comparing 10345 (924d54c) with main (e060425)

Summary

✅ 49 untouched benchmarks

@Viicos Viicos marked this pull request as ready for review September 7, 2024 13:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _model_construction.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@sydney-runkle sydney-runkle merged commit c19e3bd into main Sep 7, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the 10345 branch September 7, 2024 15:45
sydney-runkle pushed a commit that referenced this pull request Sep 9, 2024
@Viicos @sydney-runkle
Fix evaluation of stringified annotations during namespace inspection (…
2c61bfd 
…#10347)
@GDYendell GDYendell mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to evaluate type annotation 'ClassVar[str]' error when creating BaseModel with ClassVar using from __future__ import annotations
2 participants
@Viicos @sydney-runkle