Skip to content

Warn if configuration is specified on the @dataclass decorator and with the __pydantic_config__ attribute #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2024
Merged

Warn if configuration is specified on the @dataclass decorator and with the __pydantic_config__ attribute #10406

merged 4 commits into from
Sep 13, 2024

Conversation

sydney-runkle
Copy link
Contributor

Closes #10371

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 13, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51b2589
Status: ✅  Deploy successful!
Preview URL: https://8fde8074.pydantic-docs.pages.dev
Branch Preview URL: https://dataclass-config.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10406 will not alter performance

Comparing dataclass-config (51b2589) with main (656481f)

Summary

✅ 49 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  dataclasses.py
Project Total  

This report was generated by python-coverage-comment-action

Viicos
Viicos requested changes Sep 13, 2024
View reviewed changes
@Viicos Viicos changed the title disallow double config on pydantic.dataclasses Warn if configuration is specified on the @dataclass decorator and with the __pydantic_config__ attribute Sep 13, 2024
sydney-runkle and others added 2 commits September 13, 2024 11:56
@sydney-runkle @Viicos
Apply suggestions from code review
dcce535 
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runkle
linting and tests
51b2589
@sydney-runkle sydney-runkle merged commit ee09d11 into main Sep 13, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the dataclass-config branch September 13, 2024 17:31
@sydney-runkle sydney-runkle mentioned this pull request Sep 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only support one config specification location in pydantic dataclasses
2 participants
@sydney-runkle @Viicos