Skip to content

Fix variance issue in _IncEx type alias, only allow True #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2024
Merged

Fix variance issue in _IncEx type alias, only allow True #10414

merged 4 commits into from
Sep 16, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 16, 2024

Change Summary

Fixes #10335
Requires pydantic/pydantic-core#1453

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 16, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd81218
Status: ✅  Deploy successful!
Preview URL: https://18f5c34f.pydantic-docs.pages.dev
Branch Preview URL: https://inc-ex-ann-2.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10414 will degrade performances by 12.56%

Comparing inc-ex-ann-2 (dd81218) with main (a764871)

Summary

❌ 2 (👁 2) regressions
✅ 47 untouched benchmarks

Benchmarks breakdown

Benchmark main inc-ex-ann-2 Change
👁 test_complex_model_serialization 54 µs 61.8 µs -12.56%
👁 test_model_json_serialization 57.9 µs 66.1 µs -12.32%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

sydney-runkle
sydney-runkle suggested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some info to the docs re the fact that we only support True? Thanks!

@pydantic-hooky pydantic-hooky bot added the awaiting author revision awaiting changes from the PR author label Sep 16, 2024
sydney-runkle
sydney-runkle approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending test passes :)

@sydney-runkle sydney-runkle enabled auto-merge (squash) September 16, 2024 16:41
@sydney-runkle sydney-runkle merged commit 2e38ec4 into main Sep 16, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the inc-ex-ann-2 branch September 16, 2024 16:57
sydney-runkle added a commit that referenced this pull request Sep 17, 2024
@Viicos @sydney-runkle
Fix variance issue in _IncEx type alias, only allow True (#10414)
ea6115d 
Co-authored-by: sydney-runkle <sydneymarierunkle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@Viicos Viicos

Labels
awaiting author revision awaiting changes from the PR author relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include/exclude doesn't work when using False
2 participants
@Viicos @sydney-runkle