Skip to content

Fix rendering of StringContraints example #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix rendering of StringContraints example #10421

merged 1 commit into from
Sep 17, 2024

Conversation

dlax
Copy link
Contributor

@dlax dlax commented Sep 17, 2024 •
edited
Loading

Change Summary

Fix rendering of StringContraints example (https://docs.pydantic.dev/latest/api/types/#pydantic.types.StringConstraints)

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 17, 2024
@dlax dlax marked this pull request as ready for review September 17, 2024 07:06
@dlax
Copy link
Contributor Author

dlax commented Sep 17, 2024

please review

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #10421 will not alter performance

Comparing dlax:fix-stringcontraints-example-fmt (1bba9c4) with main (2f4723f)

Summary

✅ 49 untouched benchmarks

Viicos
Viicos approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. We should definitely improve our docs linting setup.

@Viicos Viicos mentioned this pull request Sep 17, 2024
Open
11 tasks
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit cf671c8 into pydantic:main Sep 17, 2024
60 checks passed
@dlax dlax deleted the fix-stringcontraints-example-fmt branch September 17, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@sydney-runkle sydney-runkle

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlax @Viicos @sydney-runkle