Skip to content

Fix stacklevel on deprecation warnings for BaseModel #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Sep 30, 2024

Warnings now display when deprecated attributes are accessed :)

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 30, 2024
@sydney-runkle sydney-runkle changed the title Fix stacklevels on deprecation warnings for BaseModel Fix stacklevel on deprecation warnings for BaseModel Sep 30, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4df96b3
Status: ✅  Deploy successful!
Preview URL: https://d755f03a.pydantic-docs.pages.dev
Branch Preview URL: https://stacklevel-fixes.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #10520 will not alter performance

Comparing stacklevel-fixes (4df96b3) with main (01b5929)

Summary

✅ 38 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 0327626 into main Sep 30, 2024
62 checks passed
@sydney-runkle sydney-runkle deleted the stacklevel-fixes branch September 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants