Skip to content

Change the signature of ConfigWrapper.core_config to take the title directly #10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

Change the signature of ConfigWrapper.core_config to take the title directly #10562

merged 2 commits into from
Oct 8, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 7, 2024

Avoids the confusing ValidateCallWrapper.__name__ attribute

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 7, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a44e24f
Status: ✅  Deploy successful!
Preview URL: https://6543cf3c.pydantic-docs.pages.dev
Branch Preview URL: https://core-config-title.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 7, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10562 will not alter performance

Comparing core-config-title (a44e24f) with main (114c914)

Summary

✅ 38 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _config.py
  _dataclasses.py
  _generate_schema.py
  _model_construction.py
  _validate_call.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle suggested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, just one docs change request (which should fix the linting error as well)

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author labels Oct 7, 2024
sydney-runkle
sydney-runkle approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sydney-runkle sydney-runkle merged commit bb7bd96 into main Oct 8, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the core-config-title branch October 8, 2024 13:03
@Viicos Viicos mentioned this pull request Oct 15, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@Viicos Viicos

Labels
awaiting author revision awaiting changes from the PR author relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sydney-runkle