Skip to content

Fix validate_call ignoring Field in Annotated #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2024
Merged

Fix validate_call ignoring Field in Annotated #10610

merged 3 commits into from
Oct 13, 2024

Conversation

kc0506
Copy link
Contributor

@kc0506 kc0506 commented Oct 12, 2024 •
edited by Viicos
Loading

Change Summary

Related issue number

fix #10569

edit: fix #10610.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

sydney-runkle
sydney-runkle approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks @kc0506!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #10610 will not alter performance

Comparing kc0506:fix-validate-call-annotated (a2f6c55) with main (28662ff)

Summary

✅ 38 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 13, 2024 11:18
@sydney-runkle sydney-runkle merged commit 2b2dffc into pydantic:main Oct 13, 2024
58 checks passed
@kc0506 kc0506 deleted the fix-validate-call-annotated branch October 14, 2024 10:05
@Viicos Viicos mentioned this pull request Apr 23, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate_call appears to ignore discriminated Unions
2 participants
@kc0506 @sydney-runkle