Skip to content

Clean up the mypy plugin implementation #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Clean up the mypy plugin implementation #10669

merged 1 commit into from
Oct 21, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 21, 2024 •
edited
Loading

Remove old versions compatibility branches, improve type checking

Closes #10197

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 21, 2024
@Viicos Viicos mentioned this pull request Oct 21, 2024
Closed
17 tasks
@Viicos
Clean up the mypy plugin implementation
9bd2580 
Remove old versions compatibility branches, improve type checking
@Viicos Viicos force-pushed the cleanup-mypy-plugin branch from f021bb9 to 9bd2580 Compare October 21, 2024 09:59
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd2580
Status: ✅  Deploy successful!
Preview URL: https://dffe7415.pydantic-docs.pages.dev
Branch Preview URL: https://cleanup-mypy-plugin.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10669 will not alter performance

Comparing cleanup-mypy-plugin (9bd2580) with main (a1ffc82)

Summary

✅ 44 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Happy to merge this.

Can we uncomment the skip for mypy type checking tests? Doesn't block this merge, but I don't want to forget about it.

@Viicos Viicos merged commit d183bf5 into main Oct 21, 2024
60 checks passed
@Viicos Viicos deleted the cleanup-mypy-plugin branch October 21, 2024 11:11
@Viicos Viicos mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supported mypy versions for the Pydantic plugin
2 participants
@Viicos @sydney-runkle