Skip to content

Make __signature__ lazy for dataclasses, too #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Nov 13, 2024

Follow up to #10818

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 13, 2024
@sydney-runkle sydney-runkle requested a review from Viicos November 13, 2024 15:56
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c714536
Status: ✅  Deploy successful!
Preview URL: https://b56b8dad.pydantic-docs.pages.dev
Branch Preview URL: https://lazy-sig-dcs.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #10832 will improve performances by 6.01%

Comparing lazy-sig-dcs (c714536) with main (783a62c)

Summary

⚡ 1 improvements
✅ 43 untouched benchmarks

Benchmarks breakdown

Benchmark main lazy-sig-dcs Change
test_construct_dataclass_schema 2.2 ms 2.1 ms +6.01%

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _dataclasses.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit b11988d into main Nov 13, 2024
55 checks passed
@sydney-runkle sydney-runkle deleted the lazy-sig-dcs branch November 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants