Skip to content

Fix URL equality with different validation methods #10934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Nov 21, 2024

Fix #10932

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 21, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b5050c
Status: ✅  Deploy successful!
Preview URL: https://4e119f6b.pydantic-docs.pages.dev
Branch Preview URL: https://url-equality-fix-2.pydantic-docs.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #10934 will not alter performance

Comparing url-equality-fix-2 (6b5050c) with main (8c4b95a)

Summary

✅ 46 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) November 21, 2024 22:34
@sydney-runkle sydney-runkle merged commit 309d4ed into main Nov 21, 2024
51 checks passed
@sydney-runkle sydney-runkle deleted the url-equality-fix-2 branch November 21, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.10: HttpUrl equality behaves differently when using model_validate vs model constructor
2 participants